search

jrkerns / pylinac

An image analysis library for medical physics
MIT License
146 stars 94 forks source link

@argue.bounds for p_tp are too tight #353

Closed bratr101 closed 3 years ago

bratr101 commented 3 years ago

Not really a bug, but a quality of life improvement for using pylinac in qatrackplus. @line 233 in tg51.py the limits on the value of p_tp are much narrower than values that can be achieved given the already existing argument limits on temperature and pressure. This should certainly be a wider range. In Alberta we regularly get p_tp>1.09, a pressure thing I guess.

I suggest the line be changed to: @argue.bounds(p_ion=(1, 1.05), p_tp=(0.89, 1.14), p_elec=(0.98, 1.02), p_pol=(0.98, 1.02))

This permits any p_tp that is achievable with valid temperature and pressure values.

jrkerns commented 3 years ago

Never would have guess such a large Ptp correction was valid. I will add some override-able constants in the module so that 1) there are reasonable defaults and 2) the user can change them if really desired.