search

jrkerns / pylinac

An image analysis library for medical physics
https://pylinac.readthedocs.io/en/latest/
MIT License
157 stars 99 forks source link

Anonymization of trajectory logs incomplete for v4.0 #399

Open keithoffer opened 3 years ago

keithoffer commented 3 years ago

I noticed that while #161 added support for reading the new metadata fields, the anoymize log features weren't updated to remove the patient information. Unfortunately due to the strange way they setup that metadata field, there is no clear offset for the patient ID, so the whole metadata field will probably have to be read, adjusted, and then written with an anoymised patient ID.

Also, once the patient ID is written the CRC at the end of the file should probably be updated. From what I can tell, binascii.crc_hqx(insert_all_bytes_here,0xFFFF) should generate the right CRC.

jrkerns commented 3 years ago

Varian's implementation of metadata is indeed a bit strange but I should able to remove it. Thanks for the tip on CRC; I never worked on updating it because I was not aware of any software checking it after post-processing. I'll split these into two separate tickets.