search

jrkerns / pylinac

An image analysis library for medical physics
https://pylinac.readthedocs.io/en/latest/
MIT License
157 stars 99 forks source link

Log Analyzer module - Class Dynalog--open file erro #418

Closed yang-6256922 closed 1 year ago

yang-6256922 commented 2 years ago

It will get an erro when loading a MLC dynalog file witch contain a chinese characters.Beacuase the patient names are chinese characters in the MLC dynalog files. The statements of 'with open(self.a_logfile) as a_log:' in class of Dynalog in log_analyzer module has no 'encoding=utf-8',that is the reason.I hope to add an 'encoding=' parameter in the Initialization function in class of Dynalog. This will lead to better compatibility of programs in countries where English is not the mother tongue.

jrkerns commented 2 years ago

Good point. Will add it.

jrkerns commented 1 year ago

Will be fixed in 3.10 due April 19/20th