search

jrkerns / pylinac

An image analysis library for medical physics
https://pylinac.readthedocs.io/en/latest/
MIT License
157 stars 99 forks source link

Use correct value for timetic #456

Closed StephenTerry closed 1 year ago

StephenTerry commented 1 year ago

I think the wrong value for timetic is being used. I believe the correct version is written in column 4 of the data rows. Using this value from the final data row, and including the gain in the calculation, I get integrated_dose to match the Corrected data as seen in the Profiler app.

jrkerns commented 1 year ago

Would you mind sending me the file you used and a screenshot of the profiler result? I'd like to add a test for it. Thanks

StephenTerry commented 1 year ago

Here you go. This fix gets the flatness and symmetry values a little closer. I've noticed the interpolation returns slightly different values for each point which may explain the rest of the difference in F&S.

On Thu, Jun 8, 2023 at 5:01 PM James Kerns @.***> wrote:

Would you mind sending me the file you used and a screenshot of the profiler result? I'd like to add a test for it. Thanks

— Reply to this email directly, view it on GitHub https://github.com/jrkerns/pylinac/pull/456#issuecomment-1583336976, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFFOIGZ2JOLRBSEIEVHLTDXKI4RLANCNFSM6AAAAAAYYROGZ4 . You are receiving this because you authored the thread.Message ID: @.***>

jrkerns commented 1 year ago

Sorry, I forgot about this. I'll be working on this this week. Thanks

jrkerns commented 1 year ago

I looked at the results for ~650 .prm files I have and the differences are small IMO except one or two configs.

image

StephenTerry commented 1 year ago

James,

Sorry it took so long to get back to you on this. My results agree with yours. They are very close to the results from the Profiler software. Thanks for making this change.

Steve

On Wed, Aug 2, 2023 at 9:10 AM James Kerns @.***> wrote:

I looked at the results for ~650 .prm files I have and the differences are small IMO except one or two configs.

[image: image] https://user-images.githubusercontent.com/4803336/257822850-7437b4b5-c230-4d55-8b88-f1a9bb61bd5b.png

— Reply to this email directly, view it on GitHub https://github.com/jrkerns/pylinac/pull/456#issuecomment-1662185919, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFFOIADISKLKBUDMV26YDDXTJGTXANCNFSM6AAAAAAYYROGZ4 . You are receiving this because you authored the thread.Message ID: @.***>