search

jrkerns / pylinac

An image analysis library for medical physics
https://pylinac.readthedocs.io/en/latest/
MIT License
153 stars 98 forks source link

VMATBase _median_profiles function returning mean profiles #483

Open keithoffer opened 7 months ago

keithoffer commented 7 months ago

I'm unsure if I'm reading things incorrectly, but in the VMATBase class (used for DRMLC and DRGS analysis), as far as I can tell, the _median_profiles() method is actually returning mean profiles. In particular, this line calls np.mean on the images, not np.median which is what I'd expect. However going back through the history, it looks like it's always been like this?

jrkerns commented 6 months ago

Yup, looks like a naming thing. Mean works better IMO in the event the field is narrower in the Y than the background. I.e. if the field were only 10cm tall on a 40cm EPID, the median would be the background value.