search

jrl-umi3218 / Eigen3ToPython

Provide Eigen3 to numpy conversion
BSD 2-Clause "Simplified" License
49 stars 10 forks source link

Incredible number of warnings #7

Closed ahundt closed 7 years ago

ahundt commented 7 years ago

Building Eigen3ToPython creates an incredible number of repeating warnings which is breaking one of my travis-ci builds because they have a log size limit of 4.0 mb.

Here is an example from one of my builds:

/home/travis/src/jrl-umi3218/Eigen3ToPython/build/src/eigen3.cpp:273:61: warning: cast from type ‘const char*’ to type ‘char*’ casts away qualifiers [-Wcast-qual]
     if (!PyArg_ParseTupleAndKeywords(args, kwargs, (char *) "", (char **) keywords)) {

Is there a clean way to actually fix the warning? If not, perhaps the flag can be set to disable it?

gergondet commented 7 years ago

All these warnings come from the code generated by PyBindGen and we cannot do anything to fix them. I've thus pushed this commit thath should silence all warnings from this package.

ahundt commented 7 years ago

@gergondet won't this block all warnings? would it be possible to just block the few relevant warnings?

  SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -w")

I know you have other bindings better than this anyway available but my build involves this version at the moment. :-)

ahundt commented 7 years ago

Also will that fail if the compiler is not gcc?

haudren commented 7 years ago

Well clang++ also has a -w flag, not sure about VisualStudio, but I don't think it will break stuff... The real good thing to do would be to find what exactly is triggering the problem in pybindgen and fix it, but we are not really supporting it anymore...