Fix for weird CMake versions

jrl-umi3218 / jrl-cmakemodules

CMake utility toolbox

https://jrl-cmakemodules.readthedocs.io/en/master/

Other

59 stars 47 forks source link

Fix for weird CMake versions #511

Closed costashatz closed 2 years ago

costashatz commented 2 years ago

In some systems (e.g. windows), the cmake version string looks like this 3.17.20032601-MSVC_2. This causes the check if(${CMAKE_VERSION} VERSION_GREATER 3.17.6) to return true, and then cmake fails (because CheckLinkerFlag does not exist). This PR does the opposite check VERSION_LESS (since VERSION_GREAT_OR_EQUAL does not exist). This is affecting my SpaceVecAlg and RBDyn builds.

costashatz commented 2 years ago

Thanks! Can you please update RBDyn and SpaceVecAlg as well to point to the new master?

Thanks!

gergondet commented 2 years ago

Can you please update RBDyn and SpaceVecAlg as well to point to the new master?

Done and done :)

costashatz commented 2 years ago

Done and done :)

Always top class support! Thanks a ton! Have a nice day!