search

jrl-umi3218 / jrl-cmakemodules

CMake utility toolbox
https://jrl-cmakemodules.readthedocs.io/en/master/
Other
57 stars 45 forks source link

Fix logging finalization as a subproject #590

Closed amiller27 closed 1 year ago

amiller27 commented 1 year ago

Previously, including e.g. ProxSuite as a subproject of a CMake project caused the call to logging_finalize to have an empty JRL_CMAKEMODULE_LOGGING_FILENAME, which caused files named ## ------------ ##\n to be created in the project source directory with contents "the rest of the stuff supposed to be written to JRL_CMAKEMODULE_LOGGING_FILENAME". This seems to fix that for my use case, but I'm not sure if it's generally correct.

Topic: logging-finalize-filename

amiller27 commented 1 year ago

Reviews in this chain: └https://github.com/jrl-umi3218/jrl-cmakemodules/pull/590 Fix logging finalization as a subproject

amiller27 commented 1 year ago
# head base diff date summary
0 a0042df8 6f76c37d diff Apr 2 3:25 AM 1 file changed, 10 insertions(+)