Duplicate implementation of git-archive-all

jrl-umi3218 / jrl-cmakemodules

CMake utility toolbox

https://jrl-cmakemodules.readthedocs.io/en/master/

Other

56 stars 46 forks source link

Duplicate implementation of git-archive-all #656

Open jorisv opened 5 months ago

jorisv commented 5 months ago

git-archive-all.sh and git-archive-all.py are both used by dist.cmake to create tar.gz archive of the sources with submodules.

The bash one is used on Windows and Linux, the Python one is used on MacOS.

Is there any reason to maintains both scripts ? If not, we can maybe use the Python script on all platform.

nim65s commented 5 months ago

I'm using https://github.com/Kentzo/git-archive-all both on linux and macos without issues, so yes, I think we can keep only the python version (and maybe consider updating it from upstream)