search

jrl-umi3218 / jrl-mal

Matrix Abstract Layer to allow multiple libraries on JRL code
GNU Lesser General Public License v3.0
5 stars 5 forks source link

Unit test fails in cfa8c25001da68fe7f77e42e2200fbf51965f0a3 #1

Closed thomas-moulard closed 13 years ago

thomas-moulard commented 13 years ago

Some headers in jrl-mal do not have CPP guards (i.e. #ifndef...#define...#endif to avoid multiple inclusions).

It seems to trigger this problem.

Is this normal?

[100%] Building CXX object tests/CMakeFiles/simple.dir/simple.cc.o
cd /home/thomas/profiles/laas/src/unstable/jrl/jrl-mal/_build/tests && /usr/lib
ccache/g++   -DBOOST_TEST_DYN_LINK -DBOOST_TEST_MAIN -Werror  -Wall -Wcast-alig
 -Wcast-qual -Wformat -Wwrite-strings -Wconversion -I/home/thomas/profiles/laas
src/unstable/jrl/jrl-mal/_build -I/home/thomas/profiles/laas/src/unstable/jrl/j
l-mal/_build/include -I/home/thomas/profiles/laas/src/unstable/jrl/jrl-mal/incl
de   -I/home/thomas/profiles/laas/install/stable/include -o CMakeFiles/simple.d
r/simple.cc.o -c /home/thomas/profiles/laas/src/unstable/jrl/jrl-mal/tests/simp
e.cc
In file included from /home/thomas/profiles/laas/src/unstable/jrl/jrl-mal/inclu
e/jrl/mal/MatrixAbstractLayerCheck.hh:28,
                 from /home/thomas/profiles/laas/src/unstable/jrl/jrl-mal/inclu
e/jrl/mal/MatrixAbstractLayer.hh:89,
                 from /home/thomas/profiles/laas/src/unstable/jrl/jrl-mal/tests
simple.cc:17:
/home/thomas/profiles/laas/src/unstable/jrl/jrl-mal/include/jrl/mal/MatrixAbstr
ctLayerBoost.hh:231: error: redefinition of ‘template double __ret_
al_matrix_ret_determinant(const boost::numeric::ublas::matrix, boost::numeric::ublas::unbounded
array > >&)’
/home/thomas/profiles/laas/src/unstable/jrl/jrl-mal/include/jrl/mal/MatrixAbstr
ctLayerBoost.hh:231: error: ‘template double __ret_mal_matrix_ret_d
terminant(const boost::numeric::ublas::matrix, boost::numeric::ublas::unbounded_array > >&)’ previously declared here
make[2]: *** [tests/CMakeFiles/simple.dir/simple.cc.o] Error 1
make[2]: Leaving directory `/home/thomas/profiles/laas/src/unstable/jrl/jrl-mal
_build'
make[1]: *** [tests/CMakeFiles/simple.dir/all] Error 2
make[1]: Leaving directory `/home/thomas/profiles/laas/src/unstable/jrl/jrl-mal
_build'
make: *** [all] Error 2
francois-keith commented 13 years ago

Indeed, the error rises because of my previous commit, but is due to the lack of guards.

If it is a simple omission, I have the patch already done, ready to be committed. I'm just waiting the confirmation.

olivier-stasse commented 13 years ago

This issues seems to have been close by commit cc5d71a9518d4523a2f9 Thus I close the issue.