jrl-umi3218 / jrl-travis

Travis build scripts
Other
7 stars 10 forks source link

Improve AppVeyor interface #31

Closed francois-keith closed 8 years ago

francois-keith commented 8 years ago

Note: 84d1393b0 removes the environment modification. This change of path removed the access to git.exe. This was a problem for calls to git -describe, required to have correct data in the pkg-config files.

gergondet commented 8 years ago

Hi Francois,

This looks good (especially the return code checking). However, as the comment indicates, putting the git folder in the path breaks project that use cmake_add_fortran_subdirectory because this puts the "wrong" sh in the path.

Can this be worked-around by providing the full git path to cmake rather than having the git directory in the path? (i.e. add -DGIT=/path/to/git to the cmake command)

francois-keith commented 8 years ago

:up: Passing the git via cmake works Also, I corrected the choco install command : the confirmation is now mandatory, otherwise it freezes waiting for the user to confirm.

gergondet commented 8 years ago

Good job :smile_cat:

bchretien commented 8 years ago

:+1: Thanks François!