jrl-umi3218 / jvrc_description

Description package for the JVRC robot
BSD 2-Clause "Simplified" License
0 stars 0 forks source link

Merge with the jvrc_description in robot-descriptions? #1

Open stephane-caron opened 7 months ago

stephane-caron commented 7 months ago

Hey guys, here is a proposal to get together :raised_hands:

Two years ago robot-descriptions / jvrc_description was spun from mc_rtc_data to serve what I believe will be a similar need to this project. The goal of the Robot Descriptions org is to facilitate access to a collection of open source robot descriptions as large and diverse as possible. The org is open to all roboticists and not geared toward any particular software. For instance there is a Python project to import robot descriptions to several frameworks like this:

from robot_descriptions.loaders.{framework_name} import load_robot_description

robot = load_robot_description("jvrc_description")  # object of framework type

(There could be something similar for mc_rtc!)

I think our needs are aligned. Would you like to merge the two projects?

@gergondet the merge should be straightforward but I can also help with time/work if there is any blocker.

gergondet commented 7 months ago

Hi @stephane-caron

I don't see why not but I'm not sure what there is to merge.

If I'm not mistaken the repository under the robot-descriptions organization has two major difference with this one:

The README is quite a bit nicer than ours though :)

On the other hand, this repository has quite a few extra files compared to the one hosted in the robot-descriptions organization (convex and calib folders which are specific to mc_rtc)

I suggest the following let me if that works for you:

Let me know if that works for you

stephane-caron commented 7 months ago

That sounds good! If it's more convenient for you at jrl-umi3218 to maintain the JVRC description here we can turn the one at robot-descriptions into a redirection :ok_hand:

Your plan makes total sense to me, we can proceed as follows:

Then once it is done: