search

jrl-umi3218 / mc_openrtm

Interface between OpenRTM and mc_rtc
BSD 2-Clause "Simplified" License
3 stars 10 forks source link

Wait until the omniorb log file is generated in clear-omninames.sh #20

Closed mmurooka closed 2 years ago

mmurooka commented 2 years ago

https://github.com/jrl-umi3218/mc_openrtm/pull/19 does not resolve the error described there, and this PR will resolve it.

The last tail command in clear-omninames.sh is causing an error if the file is not found (I guess that the log file was sometimes not generated within 1sec due to the limited computing resources on the CI), so it should be fixed. Sorry for the simple mistake :sweat:, but I still think the previous PR is not too bad (no need to revert).

With this PR patch, clear-omninames.sh will never return in the unlikely event that the omniorb service does not create a log file. Please let me know if you have any problems with this behavior.

gergondet commented 2 years ago

Thanks @mmurooka

Please let me know if you have any problems with this behavior.

In case something goes wrong in a surprising way in CI I think it's better to have this script timeout after e.g. 10 seconds, otherwise this gets stuck in an infinite loop and you don't get any feedback :(

mmurooka commented 2 years ago

@gergondet Thank you for feedback. Do you think https://github.com/jrl-umi3218/mc_openrtm/pull/20/commits/953227e190371965f79ed850259bb0f1afcf2fbb is good?