search

jrl-umi3218 / sch-core

Implementation and computation algorithms for the convex hulls
BSD 2-Clause "Simplified" License
13 stars 16 forks source link

Add override to all overriding functions #18

Closed barcode closed 6 years ago

barcode commented 6 years ago

Add override to all overriding functions (this allows the use of -Werror=suggest-override in downstream projects)

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 55.465% when pulling 1bc5b726816b611c22c34225a45a782dfadd9d01 on barcode:add_override into f814b56f69d0243f835f2899a18679aae69994fb on jrl-umi3218:master.

gergondet commented 6 years ago

Hi @barcode

Thanks for the contribution. However, sch-core is not a C++11 library so I cannot accept this PR.

If you want to avoid warnings related to this in downstream projects, I suggest you look into diagnostic pragmas or system includes.