jrl-umi3218 / sch-core

Implementation and computation algorithms for the convex hulls
BSD 2-Clause "Simplified" License
13 stars 16 forks source link

BUILD_BSD -> SCH_BUILD_BSD #25

Closed jmirabel closed 5 years ago

jmirabel commented 5 years ago

Related to #22

gergondet commented 5 years ago

Thanks for the patch.

I'm ok with renaming the option (I guess it's troublesome when the project is included in other projects) but you are missing a few changes:

I have push an update on the topic/bsd branch of the shared-tests submodule but your PR should include an update for the reference as well.

gergondet commented 5 years ago

Perfect, thanks!