jrl-umi3218 / sch-core

Implementation and computation algorithms for the convex hulls
BSD 2-Clause "Simplified" License
13 stars 16 forks source link

CMake Package Config support added #7

Closed ahundt closed 7 years ago

ahundt commented 8 years ago

see https://github.com/jrl-umi3218/jrl-cmakemodules/pull/103

ahundt commented 8 years ago

this is failing because the jrl-umi3218/jrl-cmakemodules branch needs to be merged first so the submodule clone is failing, thus the cmake run won't work right

ahundt commented 7 years ago

@gergondet do you know what's going on with this travis ci error? It seems to fail to check out a subrepository:


Submodule path 'tests/shared-tests': checked out '3b1a5b76465dcb7135b6dd30c6cb705df42ec817'
Unable to checkout '5e0e3a97b748aec181d01b666db44c938042a335' in submodule path 'cmake'
The command "eval git submodule update --init --recursive" failed. Retrying, 2 of 3.
gergondet commented 7 years ago

It indicates you pushed the wrong reference for the cmake submodule. (indeed 5e0e3a97b748aec181d01b666db44c938042a335 is not a valid reference but it is one for your fork)

My best guess is to do something like that in your local sch-core copy:

git submodule sync
cd cmake
git remote update
git checkout origin/master
cd ../
git commit -m 'Fix cmake submodule'
ahundt commented 7 years ago

okay hopefully fixed now!

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 56.888% when pulling e8f5e4d3b6ecfadc69dd273c878c5992c4c1c68c on ahundt:package into 5c3796f51ed7f0ef37a7add338e1b41c8fe06f7d on jrl-umi3218:master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 56.888% when pulling e8f5e4d3b6ecfadc69dd273c878c5992c4c1c68c on ahundt:package into 5c3796f51ed7f0ef37a7add338e1b41c8fe06f7d on jrl-umi3218:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.5%) to 56.379% when pulling da3c5cbc6625673e34cfa6ec2ed9f43acf91a4f6 on ahundt:package into 5c3796f51ed7f0ef37a7add338e1b41c8fe06f7d on jrl-umi3218:master.

ahundt commented 7 years ago

@gergondet can this be merged?