Add point object and a performance test

jrl-umi3218 / sch-core

Implementation and computation algorithms for the convex hulls

BSD 2-Clause "Simplified" License

13 stars 16 forks source link

Add point object and a performance test #8

Closed mehdi-benallegue closed 7 years ago

coveralls commented 8 years ago

Coverage increased (+0.001%) to 56.79% when pulling c35557277c758896a048e21e10336adabe1117c5 on mehdi-benallegue:master into cc947a019a622aaf7aadf054210d7b378877f5b8 on jrl-umi3218:master.

gergondet commented 8 years ago

The build passed following the merge in sch-shared-tests. It seems all comments were fixed (SCH_API is indeed useful on protected functions if one wishes to write a derived class in a separate library) so if you have nothing to add, I'll merge.

mehdi-benallegue commented 8 years ago

SCH can compute proximity queries between virtually any kind of convex objects. We could expect a user to have his own kind of convex shape and wishes to extend the base SCH classes independently from the library.

If everything else if fine you could go for the merge.

Thank you !

Mehdi-

2016-11-01 15:52 GMT+09:00 Pierre Gergondet notifications@github.com:

The build passed following the merge in sch-shared-tests. It seems all comments were fixed (SCH_API is indeed useful on protected functions if one wishes to write a derived class in a separate library) so if you have nothing to add, I'll merge.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jrl-umi3218/sch-core/pull/8#issuecomment-257500647, or mute the thread https://github.com/notifications/unsubscribe-auth/AAakp77SSUXotHfFjmA0yhwx6_3sO8KPks5q5uGcgaJpZM4Kh881 .

coveralls commented 7 years ago

Coverage decreased (-0.2%) to 56.577% when pulling 79a170f9a66c184ebf302829457db8c905ff2d8a on mehdi-benallegue:master into ab4d016ad72d99e29f54a9356153e441b2ba54df on jrl-umi3218:master.

coveralls commented 7 years ago

Coverage increased (+0.1%) to 56.888% when pulling 2a9c6f25615bd52c65cccd21728ba183ca42cb1a on mehdi-benallegue:master into ab4d016ad72d99e29f54a9356153e441b2ba54df on jrl-umi3218:master.

coveralls commented 7 years ago

Coverage increased (+0.1%) to 56.888% when pulling 2a9c6f25615bd52c65cccd21728ba183ca42cb1a on mehdi-benallegue:master into ab4d016ad72d99e29f54a9356153e441b2ba54df on jrl-umi3218:master.

mehdi-benallegue commented 7 years ago

Regarding the last comment about test/CMakeLists.txt, it was staged by mistake. It is fixed now.

coveralls commented 7 years ago

Coverage increased (+0.1%) to 56.888% when pulling 202c231646818546b0f5657cd9904f38062c9427 on mehdi-benallegue:master into ab4d016ad72d99e29f54a9356153e441b2ba54df on jrl-umi3218:master.

gergondet commented 7 years ago

Looks ok to me. For d initialization, copy elision can be applied but that's pretty much what you're doing manually and with the corrected style it's much more readable.

Merging, thanks for the contribution :cake: