search

jrleeman / rsfmodel

Rate and state frictional solver
MIT License
31 stars 12 forks source link

Add lines marking constant state and rate dependence #17

Closed jrleeman closed 9 years ago

jrleeman commented 9 years ago

Improves the figure by marking lines of constant a and rate dep. of friction. Addresses #16

jrleeman commented 9 years ago

I had just put that size since it looked nice, but this is better. Should we also return the figure and/or axis objects?

I was a little worried about the way to draw the lines of constant a. This may be somewhat clunky.

dopplershift commented 9 years ago

Returning fig is probably a good idea. Could also take/return ax the same way if you wanted.

As far as the lines, I've done something similar with my skewT code. You could create a LineCollection object instead of calling plot(), but I'm not sure that really helps readability at all. For me it was more a matter of avoiding the pyplot interface.

jrleeman commented 9 years ago

I added the fig/axes returns. I think for now I'll leave the plot call, but we could revisit if we want to.