search

jrleeman / rsfmodel

Rate and state frictional solver
MIT License
31 stars 12 forks source link

Prz fix #21

Closed jrleeman closed 9 years ago

jrleeman commented 9 years ago

Fixes a problem discovered when testing the Perrin-Rice state evolution relation. The way the relation is defined, it must have an internal reference velocity that is the system reference velocity/2*Dc. It also has a slightly different velocity contribution. I have fixed the PRZ class to reflect these changes and linted (finding spelling errors while doing so).

dopplershift commented 9 years ago

On a cursory look, it seems pretty good. It also seems like the abstractions we've chosen here are about right, since you we able to override just the right spot to fix this.

jrleeman commented 9 years ago

Great. I'll merge. It was very easy to do, so I think you're correct. Working with the model at it's current level feels pretty good!