Add extra attributes for devices when connected to network

jrlucier / eero_tracker

Eero Device Tracker for Home Assistant (HA, HASS.IO, HASS OS, HASSIO)

Other

64 stars 11 forks source link

Add extra attributes for devices when connected to network #29

Closed schmittx closed 3 years ago

schmittx commented 3 years ago

Adds extra attributes for network_name, connected_to, ip_address, and mac.

Fixes #25.

rsnodgrass commented 3 years ago

Looks good, thanks for the contribution!

schmittx commented 3 years ago

Glad to help! Any chance I can get some Hacktoberfest credit as well? The PR just needs to be labeled as hacktoberfest-accepted (more info)

jrlucier commented 3 years ago

Thanks for the contribution! I'll validate it tonight against the latest HASS and merge in if everything looks good. I've tagged the project as being within Hacktoberfest, so you should get credit ;)

schmittx commented 3 years ago

The scanner-based device tracker platform doesn't allow extra attributes to be removed when the entity is not not_home.

It's admittedly weird to see connected_to in attributes when the entity is not_home so I'd like to find a workaround at some point (if possible), but I think it's not a show-stopper at the moment.