Implemented provisional standings feature.

jrmitch120 / ChallengeBoard

Challenge Board

BSD 3-Clause "New" or "Revised" License

10 stars 7 forks source link

Implemented provisional standings feature. #11

Closed ghost closed 9 years ago

ghost commented 9 years ago

added "Provisional Standings" button to the board nav bar
added a route to handle the button
the route logic applies the match backlog without a db commit, forwards to usual standings view

This feature let's people inspect current "real" standings. The official standings usually do not reflect the truth, since usually a lot is happening in the pending queue.

jrmitch120 commented 9 years ago

Awesome man. Thanks!

I'm going to play with this some tomorrow. One thing I noticed is that it will crash if there aren't any pending matches. That's a pretty easy fix. You may have inspired me to start-up tinkering with this again.

ghost commented 9 years ago

Right, I dropped the ball there :). Should be fixed now.

jrmitch120 commented 9 years ago

I reworked the interface a little bit. I'm not sure if I like it better or not =).

Essentially I wanted to keep the standings route the same for both official and unofficial, so I made the unofficial standings trigger off a query string parm. On the interface side, you can toggle what you want to see within the standings.

What do you think? I'll put this out on ChallengeBoards.net shortly. You've rekindled my interest =).

Now to find something else to add!

ghost commented 9 years ago

Looks good! Thanks for pulling this feature.