jrmoulton / tmux-sessionizer

Tmux Sessionizer: A tool for opening git repositories as tmux sessions
MIT License
459 stars 35 forks source link

fix(build): update version + lockfile and ensure correctness in ci #85

Closed mrcjkb closed 8 months ago

mrcjkb commented 8 months ago

Hey :wave:

I noticed your last release and wanted to package it for nixpkgs. It looks like you forgot to update the version in Cargo.toml + Cargo.lock again.

This PR adds some safety, as discussed in #67, by:

I've also bumped the version in Cargo.toml to 0.4.3 and updated the lockfile. Would you be open to pushing a 0.4.3 tag, so I can package this for nixpkgs?

jrmoulton commented 8 months ago

Thanks. Haha I thought I had it right this time.

I'll push a 0.4.3 tag

mrcjkb commented 8 months ago

🤔 looks like it broke something?

junglerobba commented 8 months ago

The nix build workflow should already fail if there is a mismatch, not sure we also need to fail the release for this.

mrcjkb commented 8 months ago

The nix build workflow should already fail if there is a mismatch, not sure we also need to fail the release for this.

It should fail if the lock file is out of date, but it won't fail if the version in Cargo.toml doesn't match the release tag.