search

jrmuizel / pdf-extract

A rust library for extracting content from pdfs
396 stars 78 forks source link

Extract text from string #23

Open pickfire opened 4 years ago

pickfire commented 4 years ago

Currently extract_text only supports AsRef<Path> but what if the user wants to input from String? Why not take in anything that implements Read instead?

Hessesian commented 1 year ago

I needed to add newlines to PlainTextOutput and also implemeted this in my fork https://github.com/Hessesian/pdf-extract

joepio commented 1 year ago

@Hessesian Could you open a PR for these changes? Would love to see your improvements merged here! I'm currently using your fork.

EDIT: a similar functionality has already been added! https://github.com/jrmuizel/pdf-extract/pull/42

joepio commented 1 year ago

This can be closed because of the new extract_text_from_mem function.

Hessesian commented 1 year ago

@Hessesian Could you open a PR for these changes? Would love to see your improvements merged here! I'm currently using your fork.

EDIT: a similar functionality has already been added! #42

I added a PR, though it tracks across many forks that improved on each other, so I'm not sure how viable the merge is