Open Hessesian opened 1 year ago
@Hessesian since we both opened a PR in the last 24 hours with a lot of changes, and we're both keen on working on this project, maybe we should collaborate and try to merge our changes.
Stuff we both do:
rustfmt
and clippy
, so many changes will overlapStuff only your PR changes:
log
. Is not very difficult to refactor I think. not sure what @jrmuizel thinks of course.Stuff only my PR changes:
lib.rs
, including a lot of function signatures. That was a time-consuming task. As far as I can see, it looks like most changes from your PR to lib.rs
are linting related. Is that right? If that's the case, I think it makes sense to take my lib.rs
as a staring point.Sure, seems to be wise to create separate pull request first for the formatting changes and common issues resolved, make sure it works and then we can do separate PR's for individual features that can be tweaked.
Can you maybe go ahead with your changes that don't clash ?
@Hessesian Is possible, but I'd prefer it if my PR was merged and we than cherry pick commits from yours. I'd gladly do that, but I want to know if the changes are OK to merge. @jrmuizel what is your opinion on this?
Might be useful to have a short video meet about all of this if you want. Reach me at joep@ontola.io
I have tracked several improvements that went into multiple forks and added some of my own, including:
I understand it's a lot of changes that are not fully coherent, and can't vouch for all of them, but I'm open to cherry picks or suggestions