search

jrmullaney / obs_superbit

LSST obs package for superBIT
0 stars 2 forks source link

Some updated files, buildDector may change #9

Closed mcclearyj closed 5 years ago

mcclearyj commented 5 years ago

Hi James,

These are a few tweaks to the pipeline (Superbit_Mapper is probably the most important) but Sutieng's BuildDetector.py is going to be more up-to-date! It's worthwhile to make sure the gains are correct, though. Given Sutieng's imminent contribution, there's no need to update the master ccd0_superbit.fits.

Thanks!! Jacqueline

jrmullaney commented 5 years ago

Hi Jacqueline. Thanks for this, but I'm afraid your fork is too different from mine to be able to merge automatically/easily. I also don't know how easy it is just to merge a single file, as you suggest. Since Sutieng is working on an update to the camera, would it be possible for you to re-fork the master, then just copy your new superbitMapper into it, commit, and make a new pull request? Thanks, J

mcclearyj commented 5 years ago

Hi James,

I think there are three files that should be copied over: python/lsst/obs/superbit/superbitMapper.py https://github.com/jrmullaney/obs_superbit/compare/master...mcclearyj:master#diff-8a21cfc51443b85a58f7d583ddf7b5d7 , python/lsst/obs/superbit/makeSuperbitRawVisitInfo.py https://github.com/jrmullaney/obs_superbit/compare/master...mcclearyj:master#diff-5a393f15c00155310935e18a67e90b0b, and config/processCcd.py https://github.com/jrmullaney/obs_superbit/compare/master...mcclearyj:master#diff-ce30a832f391e695b978e76bd5e8716c. The last file can be changed slightly to make it easier to merge.

I'll do as you suggest, and reinitiate a pull request. Please let me know if this still causes problems for you.

--Jacqueline

On Thu, Dec 6, 2018 at 12:11 PM James Mullaney notifications@github.com wrote:

Hi Jacqueline. Thanks for this, but I'm afraid your fork is too different from mine to be able to merge automatically/easily. I also don't know how easy it is just to merge a single file, as you suggest. Since Sutieng is working on an update to the camera, would it be possible for you to re-fork the master, then just copy your new superbitMapper into it, commit, and make a new pull request? Thanks, J

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jrmullaney/obs_superbit/pull/9#issuecomment-445013446, or mute the thread https://github.com/notifications/unsubscribe-auth/ANd0blY0F3cFxiUzWeEKQ8SASKldlckTks5u2Xn3gaJpZM4ZEwS- .