search

jrnewell / goog-webfont-dl

A utility to download google webfonts to your local machine
MIT License
75 stars 17 forks source link

Proxy support #6

Closed micheledisalvatore closed 8 years ago

micheledisalvatore commented 8 years ago

I had problems to use it behind a proxy server, with this commit is possible to set the proxy via command line.

jrnewell commented 8 years ago

I am curious, did the environment variables HTTP_PROXY/http_proxy not work? That is usually the standard way to add a proxy to a command-line program in linux. Also do we need to think about proxy username/password?

micheledisalvatore commented 8 years ago

That environment variables are available on my system, but they didn't work. As you can see on the documentation of the module request they say that it does the same that you said, but at this point they set the proxy in the way that I implemented it.

Concerning the auth, as it is explained here, it is possible to use the current implementation, just changing the url of the proxy from http://www.myproxy.com/ to http://username:password@www.myproxy.com/

jrnewell commented 8 years ago

ok, sounds good!