search

jroal / a2dpvolume

Automatically exported from code.google.com/p/a2dpvolume
http://jimroal.com/slist.htm
95 stars 33 forks source link

Notifications read more than once #278

Closed jroal closed 5 years ago

jroal commented 5 years ago

Still have issues reading notifications. Many read twice.

cprhokie commented 5 years ago

I will take a look at this.

jroal commented 5 years ago

I added a simple check to ensure the same message does not read twice in a row to 2.12.11.7. It could be better though.

jroal commented 5 years ago

I am closing this with 2.12.11.8 for now. It should fix most of the issues most of the time.

cprhokie commented 5 years ago

Reopening because I think I found the real cause. Hope to have a fix later today.

jroal commented 5 years ago

@cprhokie so, what is the root cause then?

cprhokie commented 5 years ago

oops I accidentally pushed to this master instead of my own - sorry - I am still learning git - sorry :) please review the commit...it should fix the double message reading issue. The basic issue was a receiver being registered by the application sometimes and by the service sometimes and the application one was never being unregistered so there end up being multiple of the same receiver.

jroal commented 5 years ago

Interesting. I had actually implemented about half of that already. I am no Git expert either. I was able to work it out though. I basically put in the same fixes you had. Some of the variables you marked as unused and commented out are actually used. One of them was called "talk" and that was actually the flag for knowing if sco was registered, sort of. Anyway, I cleaned it up now. I cleaned up a few other issues like it where I used this instead of application. Thanks for the help.