#63 Notify user when trying to create a lesson with no notes

edXmO commented 3 years ago

Hi ! It's been a while, I'm sorry for not working on this before. I've been quite busy but found some time today and got something done.

Created a new style for the input title element to handle the invalid use case on form submit.
The addLesson function, now also checks for the content of input title element and replaceschanges the styling if content is invalid.
Took some time with the tooltip thingy, I was just fiddling around a bit with a span tag element and ::after pseudo-element to create a custom tooltip. Let me know if it needs a different styling, I'm not sure about the overall size and font-size so I'd appreciate feedback.
Another important question about the tooltip is the positioning. I realized that in lower screen sizes (and in the 900px media query) the positioning of the tooltip along with the clear button is a little off. I guess the answer is moving the tooltip somewhere else, but I'm not sure where to. I'd appreciate feedback on that too.

I think that's all for now, I'll be around to fix the changes on the positioning if needed. Thanks!

jrobind commented 3 years ago

Also, I forgot to mention, in future can you please create a new branch before raising a pull request.

If you need some guidance, please follow the process outlined in this article: https://www.digitalocean.com/community/tutorials/how-to-create-a-pull-request-on-github

Thanks 😃

edXmO commented 3 years ago

Also, I forgot to mention, in future can you please create a new branch before raising a pull request.

If you need some guidance, please follow the process outlined in this article: https://www.digitalocean.com/community/tutorials/how-to-create-a-pull-request-on-github

Thanks 😃

Sure, I'll create a new branch when addressing issues. Sorry for the inconvenience.

jrobind commented 3 years ago

Also, I forgot to mention, in future can you please create a new branch before raising a pull request. If you need some guidance, please follow the process outlined in this article: https://www.digitalocean.com/community/tutorials/how-to-create-a-pull-request-on-github Thanks 😃

Sure, I'll create a new branch when addressing issues. Sorry for the inconvenience.

Thanks! No need to set up a new branch for these changes, just remember for future PR's 😄

jrobind / dev-jot

#63 Notify user when trying to create a lesson with no notes #103