issue in removing the lesson while editing it.

jrobind / dev-jot

Note-taking app for online development tutorials

MIT License

54 stars 45 forks source link

Closed VIPIN24BOHRA closed 3 years ago

VIPIN24BOHRA commented 3 years ago

To get the issue follow these steps :

create a new single lesson.
Click on the edit button.
now click on the remove lesson button.
now try to update the lesson it will not get updated or added.
and after removing the lesson the submit button should show "Add lesson " instead of "Update lesson".

hopefully I am able to convey the issue.

VIPIN24BOHRA commented 3 years ago

Solution : first solution:

hide the lesson when we are updating it so that the user can't delete it while updating. as there is no point in deleting while updating.

second solution.

we can make some changes to the code so that after removing the lesson while editing it should not create a problem.

we should also change the "Update lesson " to "Add lesson " on deleting the lesson while editing it. it will require just a few lines of code.

jrobind commented 3 years ago

Thanks for raising this issue! I'll try and reproduce this later today when I get some time.

Feel free to take this on if you'd like 😄

VIPIN24BOHRA commented 3 years ago

Sure I would like to work on it.