search

jrobind / dev-jot

Note-taking app for online development tutorials
MIT License
54 stars 45 forks source link

Convert CSS to SASS/SCSS – vanilla app #113

Open jrobind opened 3 years ago

jrobind commented 3 years ago

It would be nice to refactor our styles so they are more maintainable and reusable. A few considerations for this:

We've recently added Gulp but it might make more sense to use Webpack and let it handle code minification, asset optimisation and SASS to CSS compilation.

These are just some ideas and suggestions – this is open for discussion 😄

muzamil301 commented 3 years ago

@jrobind let me know if no one started

jrobind commented 3 years ago

Hey @muzamil301, I'd recommend just working on one ticket at a time for now 😄

muzamil301 commented 3 years ago

😄 got your point

SakaRicky commented 3 years ago

I guess it's more appropriate to continue here. So I will do this for the vanilla part.

SakaRicky commented 3 years ago

Hi have been working on this issue but I have a problem. When I open the index.html file in the public folder of the main-app I get this Screen Shot 2021-06-25 at 15 56 47 Have I screwed something? I cloned it again from fresh in another local dir but still the same

SakaRicky commented 3 years ago

Is there something I'm missing ?

akashpatil14298 commented 3 years ago

Hi @jrobind , If this issue is open, I would like to work on it..

SakaRicky commented 3 years ago

Yeah you can proceed with it.

On Sun, 8 Aug 2021 at 11:14 akashpatil14298 @.***> wrote:

Hi @jrobind https://github.com/jrobind , If this issue is open, I would like to work on it..

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/jrobind/dev-jot/issues/113#issuecomment-894774632, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADY4OZKQFAYWC4FF4HRJJLLT3ZKINANCNFSM42RNDY2Q .

priyang12 commented 3 years ago

is issue still open???

SakaRicky commented 3 years ago

Yes, it is.

On Tue, 14 Sep 2021 at 19:06 Priyang @.***> wrote:

is issue still open???

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/jrobind/dev-jot/issues/113#issuecomment-919392701, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADY4OZPJKTBMRIJ4VDQ7QU3UB6FMFANCNFSM42RNDY2Q .

priyang12 commented 3 years ago

@jrobind i have Change the CSS to SCSS in #140 PR