search

jrobind / dev-jot

Note-taking app for online development tutorials
MIT License
54 stars 45 forks source link

Add unit/integration testing #118

Open gaddscientist opened 3 years ago

gaddscientist commented 3 years ago

Hi, I'm interested in adding some tests to the vanilla JS app for a college course I'm taking. I wanted to get approval and have this issue assigned to me if that is something that would be beneficial to contribute. Let me know what you think, thanks.

jrobind commented 3 years ago

Hey @hilldrupbf, thanks for opening this issue.

This sounds great and would be very helpful. I'll mark this as in progress and assign it to you. We do have some example (rather contrived) jest tests which you could use as a starting point (or feel free to remove).

If you have any comments, questions, or general ramblings feel free to just comment here (or join the Discord server and ping in the open-source-project text channel).

Thanks!

gaddscientist commented 3 years ago

Hi, I've created a pull request to be reviewed, but wanted to additionally comment here to see if you'd remove the in progress label to open up the issue to anyone who may want to get their hands on some testing. Or perhaps close this issue and you could open a new one with more information if you would prefer. Thanks!

jrobind commented 3 years ago

Hi, I've created a pull request to be reviewed, but wanted to additionally comment here to see if you'd remove the in progress label to open up the issue to anyone who may want to get their hands on some testing. Or perhaps close this issue and you could open a new one with more information if you would prefer. Thanks!

Thanks Bryan, I've removed the label and unassigned you from this. Thanks for submitting an awesome PR – just left a few comments on it for you!

Regarding this ticket, I agree with your suggestion – let's leave this open for somebody else to have a crack at some testing.