jrobind / dev-jot

Note-taking app for online development tutorials
MIT License
54 stars 45 forks source link

Notes should be scrollable in the preview pane #86

Closed MSoup closed 3 years ago

MSoup commented 3 years ago

Instead of the text simply being cut off, it would be nice to be able to scroll through the text preview. The whole text is being loaded anyway, isn't it? If it isn't, then I guess we save some bytes (potentially kilobytes at best) of data by only having the preview show a max limit, but if it is, then a scrollable implementation would be easier than having to manually click "view lesson." (Imagine if you had 30+ lessons)

preview

jrobind commented 3 years ago

Thanks for raising this. Totally agree, this will become really annoying fast, especially if lesson content looks similar. I think the whole text is being loaded.

yep, looks like it's the entire lesson content:

https://github.com/jrobind/dev-jot/blob/master/app-main/public/js/index.js#L241

nimiakinleye commented 3 years ago

Nice Idea, I decided to work on this since I didn't find an 'in progress' tag.

jrobind commented 3 years ago

Thanks @nimiakinleye, I'll review the PR later today 😃

jrobind commented 3 years ago

Closed by #91