search

jrochkind / bento_battle

2 stars 0 forks source link

No styling after checkout #1

Closed lawlesst closed 10 years ago

lawlesst commented 10 years ago

I've checked out this app and successfully configured it to search two APIs. However, something is not quite right with the asset pipeline. I get no CSS styling, including Bootstrap.

I compared the setup with that of your sample_megasearch (which is styled after a checkout) and can't seem to find the difference. Could you take a quick look and see if anything jumps out at you?

Thanks for your time.

lawlesst commented 10 years ago

I have the styling working now. Not sure if this is the best approach but it's working.

I changed application.css to application.css.scss with this:

@import "battle";
@import "bootstrap_local";
jrochkind commented 10 years ago

For a second I didn't realize we were in the bento_battle repo and not the bento_search repo, and got confused!

Yeah, this isn't really a complete polished application, just a prototype. It looks like the battle css file is actually empty, and you might as well not include it. But the bootstrap_local I guess you need? Not sure why that wasn't in the repo if it's really needed. Feel free to make a pull request if it seems to work better with it. Thanks!

jrochkind commented 10 years ago

Also, very curious what you guys are doing with bento_battle, if you had time I'd be super happy to receive an email from you with what you're doing, and how it's working out as you progress and finish! I'm so glad it's looking useful to you!

jrochkind commented 10 years ago

Ah, so this line in the existing application.css:

https://github.com/jrochkind/bento_battle/blob/master/app/assets/stylesheets/application.css#L13

Should have imported all the other .css files with the require_tree . statement. That's what it did for me. I'm not sure why it wasn't doing that for you. Did require_tree somehow stop working in Rails4 maybe? Not sure, sorry!

lawlesst commented 10 years ago

Thanks for the info. I'm still getting up to speed with the Rails conventions so I was a bit lost. I'm able to style it now so I think I'm all set.

I'll send you an email with more details but at this stage we are exploring doing something like what you wrote about in the Code4Lib journal with a couple of different vendors. Still very early in the process though.

Thanks again.