get tests running again

jrochkind / faster_s3_url

Optimized generation of public and presigned AWS S3 GET URLs in ruby faster

MIT License

84 stars 7 forks source link

Closed jrochkind closed 10 months ago

jrochkind commented 10 months ago

Haven't touched this in a while, as usual I find that CI is not green. Let's fix.

aws gem now has implicit dependency on an XML processor such as nokogiri, add for dev
response-expires header format match recent AWS ruby SDK with #httpdate

jrochkind commented 10 months ago

Oh wow, there's an actual test failure... AWS gem is now using a different time format for response-expires header... let's change to match.

jrochkind commented 10 months ago

Ha, that date format change was a result of an issue we ourselves filed with ruby AWS sdk! https://github.com/aws/aws-sdk-ruby/issues/2415