search

jrochkind / faster_s3_url

Optimized generation of public and presigned AWS S3 GET URLs in ruby faster
MIT License
84 stars 7 forks source link

Use CGI.escapeURIComponent avail in ruby 3.2 for improved performane, now requires minimum ruby 3.2 #8

Open jrochkind opened 4 months ago

jrochkind commented 20 hours ago

Oops, forgot this, will be merging and releasing it soon!

@BenKanouse since you are around and the only user I am in touch with -- do you think dropping support for rubies older than 3.2 in next release is reasonable? And do you think that would require a major version bump?

(If users really do want support, we could put some kind of conditional in to get this advantage but still support both, but when I wrote this I was thinking it wasn't necessary, curious if you have feedback!)

BenKanouse commented 19 hours ago

The app I hope to use this gem in happens to be on 3.3.x so that would work fine for me.

I do have other apps that are on 3.0.x, but I hope to update those before using this gem.