search

jrockway / cperl-mode

cperl-mode with 5.10 fixes, mx-declare support, perl6 support, etc.
102 stars 33 forks source link

q-ish quotes need a space to syntax color properly. #25

Open matthewpersico opened 10 years ago

matthewpersico commented 10 years ago

Using the latest here, typing q(a string) does not highlight the 'q'. Ditto qx,qr, etc. Putting a space in there, i.e. q (a string) highlights the q. I tried to figure out where it's happening but to no avail. What's even worse is that 18 months ago, I DID figure it out and fix it, but I left that code at an old job and I'm not sure now if I fixed this version or the one in the SUMO or the one that is embedded in XEmacs proper. Any idea where I can start looking so I can try to reproduce my fix?

choroba commented 10 years ago

Works for me. 1

jrockway commented 10 years ago

I'm also seeing it work, and don't recall any funny business with that.

The code is very hairy, though, so I'm sure it breaks under some cases :)

On Fri, Oct 10, 2014 at 3:58 PM, E. Choroba notifications@github.com wrote:

Works for me. [image: 1] https://cloud.githubusercontent.com/assets/886196/4598345/d34cee94-50b7-11e4-9602-140184cab422.png

— Reply to this email directly or view it on GitHub https://github.com/jrockway/cperl-mode/issues/25#issuecomment-58708233.

matthewpersico commented 10 years ago

I'm using XEmacs 21.5.34, dated June 2013. I'm using the cperl-mode.el from the xemacs-sumo-2010-07-27 which has this identifying mark:

;; $Id: cperl-mode.el,v 6.2 2008/04/14 23:14:52 vera Exp vera $

Am I out of date?

Am I mismatched with XEmacs version? bad_q

jrockway commented 10 years ago

There appear to be some workarounds for XEmacs in the code, but I don't really understand those and am guessing that they're causing problems here :)

Honestly, they can probably be removed. You might give that a try and send me a pull request if it fixes the problem. I don't care too much about support XEmacs from 1993 ;)

On Fri, Oct 10, 2014 at 9:37 PM, matthewpersico notifications@github.com wrote:

I'm using XEmacs 21.5.34, dated June 2013. I'm using the cperl-mode.el from the xemacs-sumo-2010-07-27 which has this identifying mark:

;; $Id: cperl-mode.el,v 6.2 2008/04/14 23:14:52 vera Exp vera $

Am I out of date?

Am I mismatched with XEmacs version? [image: bad_q] https://cloud.githubusercontent.com/assets/3129206/4601009/13f2831c-50e7-11e4-9358-7e97ea75e051.JPG

— Reply to this email directly or view it on GitHub https://github.com/jrockway/cperl-mode/issues/25#issuecomment-58733913.

renormalist commented 6 years ago

I tend to close this issue soon as 'wontfix' for cleanup reasons. Feel free to object...