search

jrodrigv / PhysicsRangeExtender

This is a KSP mod that will extend the physics range
The Unlicense
32 stars 11 forks source link

Memory leak detected by KSPCF #24

Open BrettRyland opened 2 years ago

BrettRyland commented 2 years ago

The KSP Community Fixes mod detects a of memory leak in PRE that is easily fixable:

[KSPCF:MemoryLeaks] A destroyed PhysicsRangeExtender:PhysicsRangeExtender instance is owning a onVesselSituationChange GameEvents callback. No action has been taken, but unless this mod is relying on this pattern, this is likely a memory leak.

In OnDestroy in PhysicsRangeExtender.cs#L75

GameEvents.onVesselSituationChange.Add(SituationChangeFixes);

should be

GameEvents.onVesselSituationChange.Remove(SituationChangeFixes);