jroimartin / gocui

Minimalist Go package aimed at creating Console User Interfaces.
BSD 3-Clause "New" or "Revised" License
9.92k stars 608 forks source link

[Windows] Vertical resize only expanding view #102

Closed Fjolnir-Dvorak closed 7 years ago

Fjolnir-Dvorak commented 7 years ago

The view is not resized to a smaller size if I am descreasing the vertical axis of the terminal. Tested on windows 10 Powershell, cmd, GitCMD. Well, powershell is special because here only the enlarenment is working...

... just started to program in go using this library / tool so I am not yet ready to solve and commit this issue on my own.

Fjolnir-Dvorak commented 7 years ago

And silly me commited the issue to gocui without checking if wuzz just used the library in a wrong way or forgot something to implement. I am sorry.

Fjolnir-Dvorak commented 7 years ago

It seems like the responsibility lies in this project. the value gocui.Gui.Size is not changing for negativ changes in the height of the terminal. To be sure I tested this scenario on all linked child projects getting the same results.

jroimartin commented 7 years ago

I've just added the following example: size. Can you run it from the different terminals and check if the values change accordingly to the resize event?

gocui uses termbox-go under the hood, which is the package used to interact with the terminal:

https://github.com/jroimartin/gocui/blob/master/gui.go#L425

So, if it does not work, it should be reported to termbox-go.

jroimartin commented 7 years ago

I'm closing the issue, as it doesn't seem to be related to gocui.