source and target reverse

jrosebr1 / color_transfer

Performs color transfer between two images. Loosely based on the "Color Transfer between Images" paper by Reinhard et al., 2001.

http://www.pyimagesearch.com/2014/06/30/super-fast-color-transfer-images/

MIT License

484 stars 149 forks source link

source and target reverse #11

Open XinArkh opened 3 years ago

XinArkh commented 3 years ago

I believe the original paper means that we want the source image to mimic the color performance of the target image, and output a transferred source image. However, in your implementation, the target image is instead transferred. This is what makes the following formulas inconsistent with the paper.

https://github.com/jrosebr1/color_transfer/blob/6724ccf927f2e3838ccd3f3da8b2542b79c9bf2f/color_transfer/__init__.py#L50-L68

InnovArul commented 3 years ago

As I understand from the paper, the else case (i.e., preserve_paper = False) is actually the same as the paper. Am I right?