search

jrosen48 / districts-facebook

0 stars 1 forks source link

setup targets - basic prelim analysis #1

Closed datalorax closed 4 years ago

datalorax commented 4 years ago

This switches us over to targets instead of using drake. I also did some super basic analysis. I wrote a function to "prep the data" but all it really does at this point is clean the names with janitor and remove one extreme case on the performance metric. We should probably remove more of those. I looked at the actual post I removed and it was just a mistake, I think. They posted an empty post. So it got way less engagement than typical, meaning it was estimated with a super low performance metric.

I mentioned this in slack, but we also should think about how we want to handle the _targets objects. I think we probably want to ignore that folder and make people (me and you) run it on our local. Otherwise, we're basically uploading the raw data. I can't figure out how to actually access that data, but that doesn't mean others couldn't figure it out. And, actually, now that I'm thinking about it, others could run the plan and then they could see the data. So... I've just convinced myself we should definitely ignore it. I'll make that switch before we merge.

datalorax commented 4 years ago

Okay, I think this is ready to be merged now, but take a look and see what you think

jrosen48 commented 4 years ago

looks great DA, merging and then taking a peak for now