search

jrosen48 / districts-facebook

0 stars 1 forks source link

super minor parsing failure #3

Open jrosen48 opened 4 years ago

jrosen48 commented 4 years ago 
Warning: 2 parsing failures.
   row                  col               expected  actual                                                                                                                    file
 84259 Overperforming Score no trailing characters ,749.64 '/Users/jrosenb8/districts-facebook/data/2020-09-25-15-52-33-EDT-Historical-Report-District-2020-02-01--2020-03-01.csv'
100918 Overperforming Score no trailing characters ,606.81 '/Users/jrosenb8/districts-facebook/data/2020-09-25-15-52-33-EDT-Historical-Report-District-2020-02-01--2020-03-01.csv'

Warning: 1 parsing failure.
  row                  col               expected  actual                                                                                                                    file
12285 Overperforming Score no trailing characters ,961.01 '/Users/jrosenb8/districts-facebook/data/2020-09-25-16-01-15-EDT-Historical-Report-District-2020-05-01--2020-06-01.csv'
datalorax commented 4 years ago

Yeah I saw that too. We should just specify the column types, probably, or at least for these few. That will make the warning go away and make sure it's parsing how we want.

jrosen48 commented 4 years ago

thought this would address it, but doesn't seem to; is it something other than a column type-related error (the no trailing characters part)?

https://github.com/jrosen48/districts-facebook/blob/72501a769cff7f341231b1b5c5a03ae19a4c53a7/R/functions.R#L3

jrosen48 commented 4 years ago

This seems silly, but wondering if the issue has to do with the Overperforming column sometimes being an integer, and other times being a double?

datalorax commented 4 years ago

I'm really surprised that function doesn't fix the warning. It does seem like it's something to do with expecting a double but then detecting an integer. But if it's named explicitly I'm not sure why it would matter.