search

jrossignol / ContractConfigurator

A config file based solution for creating new contracts for Kerbal Space Program.
https://forum.kerbalspaceprogram.com/index.php?/topic/91625-1
Other
64 stars 67 forks source link

RecoverVessel doesn't appear to be recognized in Space Center view #343

Open inigmatus opened 9 years ago

inigmatus commented 9 years ago

Attempted to recover landed vessel using RecoverVessel ... but only after exiting to Space Center. Vessel could be recovered, but recovery was not recognized by Contract.

Essentially my goal is to find a way to test for recovery of Kerbal and craft separately, and from the Space Center.

jrossignol commented 9 years ago

This one is unfixable without re-writing large amounts of code that rely on Vessel rather than vessel id or ProtoVessel. I'll have to think about what to do with RecoverVessel, but for now I'd recommend using ReturnHome over RecoverVessel for most scenarios.

inigmatus commented 8 years ago

I will need to test, but I think RecoverKerbal is affected by this as well. With passenger contracts, the intent is to recover returning passengers to complete the contract (so players can't abuse them after contract completion).

jrossignol commented 8 years ago

RecoverKerbal should not be affected - please raise a separate issue if you think there is a problem there. On Dec 9, 2015 9:57 AM, "inigma" notifications@github.com wrote:

I will need to test, but I think RecoverKerbal is affected by this as well. With passenger contracts, the intent is to recover returning passengers to complete the contract (so players can't abuse them after contract completion).

— Reply to this email directly or view it on GitHub https://github.com/jrossignol/ContractConfigurator/issues/343#issuecomment-163323726 .

inigmatus commented 8 years ago

RecoverKerbal works perfect. Recoding my contracts now for RecoverKerbal as I consider RecoverVessel bugged (players will invariably attempt recovery of aircraft from Space Center View). You might want to put a note on this limitation in the wiki for now so modders are given a heads up.