jrossignol / ContractConfigurator

A config file based solution for creating new contracts for Kerbal Space Program.
https://forum.kerbalspaceprogram.com/index.php?/topic/91625-1
Other
64 stars 67 forks source link

There are `canHaveKolniya`, but not `canHaveSynchronous`? #581

Closed luiges90 closed 7 years ago

luiges90 commented 7 years ago

I was reading this page https://github.com/jrossignol/ContractConfigurator/wiki/CelestialBody-Type and found that that are CanHaveKolniyaOrbit and CanHaveTundraOrbit but not CanHaveSynchronousOrbit, despite the latter is also potentially useful (esp. for moons)

jrossignol commented 7 years ago

It's a stock thing - those are hooks into the stock methods. Basically, the CanHaveSynchronousOrbit doesn't exist because in the stock solar system there are no bodies that can't have a synchronous orbit (at least, I think that is the case, but seriously wondering if that is true for Gilly...)

jrossignol commented 7 years ago

Oh yeah, definitely possible on Gilly, just verified. If you're able to find a body (stock or mod) that cannot support a Synchronous orbit (due to rotating too fast or having too small of an SOI), then I'll reopen this.

Kerbas-ad-astra commented 7 years ago

According to the Wiki, Moho, the Mun, Ike, and all the moons of Jool have synchronous orbits outside their SOIs.

jrossignol commented 7 years ago

Though I reopened this already. Will be looked at in a future release.

jrossignol commented 7 years ago

Added CelestialBody.CanHaveSynchronousOrbit() to next release.