search

jrossignol / ContractConfigurator

A config file based solution for creating new contracts for Kerbal Space Program.
https://forum.kerbalspaceprogram.com/index.php?/topic/91625-1
Other
64 stars 67 forks source link

seconds per Earth day should not be 86400 #648

Open GrKl30 opened 6 years ago

GrKl30 commented 6 years ago

looking through the code to find something, I stumble across this: SecondsPerDay = 86400; // = 24h in Util/DurationUtil.cs If this is made for RSS, this is wrong. RSS has 23h56m04s = 86164s This would of course also affect the 'SecondsPerYear': 86164*365 = 31449860 instead of 31536000

jrossignol commented 6 years ago

Hmmm... I think someone submitted a pull request that may change this, but not sure. It's not directly made for RSS but for the earth time settings in KSP. As a result I don't know if it sounds be using the sidereal period or not.

Is this breaking something specific?

On Jan 19, 2018 5:03 AM, "GrKl30" notifications@github.com wrote:

looking through the code to find something, I stumble across this: SecondsPerDay = 86400; // = 24h in Util/DurationUtil.cs If this is made for RSS, this is wrong. RSS has 23h56m04s = 86164s This would of course also affect the 'SecondsPerYear': 86164*365 = 31449860 instead of 31536000

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/jrossignol/ContractConfigurator/issues/648, or mute the thread https://github.com/notifications/unsubscribe-auth/AIUFdfN2zr0Czd4LkLtef3p2pL7fmRGCks5tMIR2gaJpZM4RkYTe .

GrKl30 commented 6 years ago

oh no, no bugs that I have noticed, this 'might' (I could check) affect missions requiring an object to stay in orbit for 1d, but even if it has ~4m difference would not kill anyone ;-)