search

jrossignol / ContractConfigurator

A config file based solution for creating new contracts for Kerbal Space Program.
https://forum.kerbalspaceprogram.com/index.php?/topic/91625-1
Other
64 stars 67 forks source link

Fix for GPP to display Gael in correct case #666

Closed JakeOliver-UK closed 4 years ago

JakeOliver-UK commented 6 years ago

At present because Gael's display name is Gael but it's body name is Kerbin it displays Gael in lowercase. This would stop this from happening.

jrossignol commented 6 years ago

This isn't a good fix. Why does Gael need to have a body name of Kerbin?

JakeOliver-UK commented 6 years ago

I'm not sure myself, but because the display name isn't the same as the body name it's causing contracts made with CC to display the planet name in lower case. Is there perhaps another way around this?

jrossignol commented 6 years ago

Well, my first thought is this is a problem with GPP only changing the display name.

On Wed, Jun 27, 2018, 8:49 AM Pleb87, notifications@github.com wrote:

I'm not sure myself, but because the display name isn't the same as the body name it's causing contracts made with CC to display the planet name in lower case. Is there perhaps another way around this?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/jrossignol/ContractConfigurator/pull/666#issuecomment-400700686, or mute the thread https://github.com/notifications/unsubscribe-auth/AIUFdbF11gzIeKQRYBE9whl8kx2VABkUks5uA5uCgaJpZM4U5WPx .

DeltaDizzy commented 4 years ago

Sorry for the necro, but this isn't something Galileo had a choice with. In KSP, the homeworld MUST be named Kerbin or the game will get very buggy. The workaround is to instead change displayName.

jrossignol commented 4 years ago

Based on @DeltaDizzy's comment I've made an alternate fix that should hopefully fix this.