jrossignol / ContractConfigurator

A config file based solution for creating new contracts for Kerbal Space Program.
https://forum.kerbalspaceprogram.com/index.php?/topic/91625-1
Other
64 stars 67 forks source link

Do stock contracts not generate when there are too many CC contracts? #674

Open jrossignol opened 5 years ago

jrossignol commented 5 years ago

Need to investigate, based on the CC thread.

https://forum.kerbalspaceprogram.com/index.php?/topic/91625-16x-contract-configurator-v1271-2018-12-28/&do=findComment&comment=3517196

Morbidous commented 3 years ago

I think this is related to what I was going to post, so I'll put it here rather than starting a new issue.

I don't know how it works, but I think that the logic on the RescueAndRecovery category is backwards (or something ends up making it backwards?) so that if it's turned on, you don't get any of those contracts, and if it's turned off you do.

This was my second time playing with CC and various contract packs, and noticed again that there were almost no rescue missions. In fact, I did exactly one, may have seen a few others, but after some point have had zero.

To try to figure out what was going on, I turned off all contracts except RescueAndRecovery, fast forwarded a few weeks, and then just had a few random science and part test contracts. I then tried turning everything off, including RescueAndRecovery, and then had nothing but rescue and recovery contracts listed.

I don't know enough about the underlying systems to be able to guess at why this might be happening.

Morbidous commented 3 years ago

Ok I think it might not be backwards. I think what it is is that the Settings do not take effect until the second time you visit the settings window. Pretty consistently if you change a setting and go check contracts, nothing changed, but if you go visit the settings window again and change nothing but still hit Accept, then go check contracts then your changes take effect.

So, it looked like the setting was backwards, since it would always be 1 step behind.

As for what causes there to be zero R&R contracts, I haven't determined that yet.

Morbidous commented 3 years ago

After some more testing, I think my guess for what's happening is that there seems to be only so many stock contract slots, and their sorting must be such that R&R contracts are always nearer the bottom, and only the ones on top make it through.

Also, accepting stock contracts seems to reduce the number of offered stock contracts, so that there's only ~10-14 stock contracts both offered and accepted. Since I have 6 stock contracts accepted, only 4-5 are offered (alongside ~38 contract pack contracts). So with only about 4 stock contracts showing up, there's virtually no chance for the rescue ones to appear. If I cancel all my contracts, and then fast forward, I can see the occasional R&R contract make it through when there are 14 stock contracts listed, though it still takes many months for that to happen.