search

jrossignol / ContractConfigurator

A config file based solution for creating new contracts for Kerbal Space Program.
https://forum.kerbalspaceprogram.com/index.php?/topic/91625-1
Other
64 stars 67 forks source link

Facility requirements of maxLevel=2 produces requirement text like minLevel=1 #681

Closed histalonia closed 5 years ago

histalonia commented 5 years ago

Facility requirement check of maxLevel=2, produces the following requirement text: The Mission Control Building must be at least level one:

This should be something like: no higher than level two or not level 3.

Here is config code from the contract: REQUIREMENT { name = FacilityMissionControl type = Facility facility = MissionControl maxLevel = 2 checkOnActiveContract = false }

jrossignol commented 5 years ago

Fixed via 5889c212057fcf7bd987868622c850e704810f98. Technically it's still bugged if someone has minLevel=1 and maxLevel=3, but that's a bit of a silly case.

jrossignol commented 5 years ago

Also, if you grab the ContractConfigurator.dll from the link above you can test the fix for yourself (although it's only a display bug).

histalonia commented 5 years ago

Will 1.28 work in 1.7.3? If not can you release a 1.27.2 version with the fix for KSP 1.7.3? Thanks so much for maintaining this mod.

jrossignol commented 5 years ago

It won't work in older versions of KSP, and I won't release for old versions unless there's a major issue. In this case is a display issue, and you should be able to work around it by providing your own requirement text.

On Sun., Nov. 3, 2019, 7:50 a.m. histalonia, notifications@github.com wrote:

Will 1.28 work in 1.7.3? If not can you release a 1.27.2 version with the fix for KSP 1.7.3? Thanks so much for maintaining this mod.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/jrossignol/ContractConfigurator/issues/681?email_source=notifications&email_token=ACCQK5MMDJOOXWWTZ2QGAQ3QR3JLNA5CNFSM4JIBVTKKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEC5ULJI#issuecomment-549143973, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACCQK5KGMDD65X6Y4BBJDWLQR3JLNANCNFSM4JIBVTKA .