search

jrossignol / ContractConfigurator

A config file based solution for creating new contracts for Kerbal Space Program.
https://forum.kerbalspaceprogram.com/index.php?/topic/91625-1
Other
64 stars 67 forks source link

maxDeltaVeeVacuum bug #704

Open wolffy-au opened 3 years ago

wolffy-au commented 3 years ago

I think you have a bug in ReachState.cs. Looks like the Actual and Vacuum checks are both using TotalDeltaVActual.

    private bool CheckVesselDeltaVeeActual(Vessel vessel)
    {
        double deltaVee = vessel.VesselDeltaV.TotalDeltaVActual;
        return deltaVee >= minDeltaVeeActual && deltaVee <= maxDeltaVeeActual;
    }

    private bool CheckVesselDeltaVeeVacuum(Vessel vessel)
    {
        double deltaVee = vessel.VesselDeltaV.TotalDeltaVActual;
        return deltaVee >= minDeltaVeeVacuum && deltaVee <= maxDeltaVeeVacuum;
    }