search

jrossignol / ContractPack-AnomalySurveyor

Contract Pack for surveying anomalies in Kerbal Space Program
10 stars 4 forks source link

Bug fix revealed by MM 3.1.2 #14

Closed alex-dev closed 1 year ago

alex-dev commented 5 years ago

MM 3.1.2 flags this as an error. It was an error before but MM was suppressing it.

tofof commented 5 years ago

This PR has @CONTRACT_TYPE[AS_*]:HAS[#tag[SCANsat]]:NEEDS[SCANsat],*

The comma and star at the end are also wrong.

Should be @CONTRACT_TYPE[AS_*]:HAS[#tag[SCANsat]]:NEEDS[SCANsat]

Still better than what is currently included, though and at least doesn't error.

alex-dev commented 5 years ago

Should it? The final ,* has well defined meaning. I don't know what is the default behaviour.

tofof commented 5 years ago

It causes a warning from MM.

alex-dev commented 5 years ago

Removed.