jrossignol / WaypointManager

MIT License
38 stars 14 forks source link

[Bug] RSS compatibility #59

Closed PhineasFreak closed 4 years ago

PhineasFreak commented 5 years ago

It has come to my attention (in a rather...bad way) that WaypointManager breaks under RSS. The reason is that WaypointManager checks for the original CelestialBody names and not the final ones (edited by the Kopernicus cbNameLater parameter).

Some minimal changes that i did locally seem to fix most of the problems:

1) Replacing b.name with b.bodyName 2) Replacing w.celestialName with w.celestialBody.bodyName

One issue that remains is that the "KSC" waypoint (always visible by default) is listed under the "Sun" celestial (the actual waypoint is nowhere to be found though). After some digging around it looks like that it is populated by KSP itself (so it is most probably a bug with Kopernicus and not WaypointManager).

From a quick testing implementing the two above changes i was able to stop the "Couldn't find celestial body with name 'Kerbin'" log spam, open the WaypointManager interface and add/remove/edit/import waypoints (from external files).